Skip to content

fix(www): API Pages Responsive #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DuskoPeric
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Api pages are not responsive

Closes #4816

What is the new behavior?

Api pages are responsive

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 4aa9e36
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6850831c24bb9f00087954a4

Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 4aa9e36
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/6850831c6c5ff0000855cefc
😎 Deploy Preview https://deploy-preview-4821--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
I only notice a double scroll bar on a normal screen (this is also the case before these changes).

https://ngrx-site-v19.netlify.app/api/store/createActionGroup

image

We can create a new issue for this if it isn't in scope of this issue.

@DuskoPeric
Copy link
Contributor Author

Thanks @timdeschryver for the review and approval. Maybe that double scroll bar should be in new issue like you suggest.

overflow-x: auto;
overflow-x: scroll;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the fix in the previous PR to remove duplicate horizontal scroll bars on the page. We can revert it to overflow-x: auto.

Comment on lines +15 to +17
@media only screen and (max-width: 1280px) {
overflow-x: hidden;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed. It's better to show the scrollbar if needed instead of hiding it and disabling scroll functionality. If the scrollbar is unnecessarily displayed, we should identify which element causes the issue and fix its width.

Comment on lines +45 to +47
@media only screen and (max-width: 1280px) {
white-space: pre-wrap;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For code parts, we can leave horizontal scrollbars. With pre-wrap, code won't be formatted and scroll bars will remain for empty content:

1

@markostanimirovic markostanimirovic added the Needs Cleanup Review changes needed label Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Cleanup Review changes needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Docs] Make API Pages Responsive
3 participants