Skip to content

docs(www): only enable scroll position on backward navigation #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2025

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The scroll position is always restored.
This is not very useful when you read a page, scroll to the bottom, navigate to another page.
I expect to scroll to the top, instead the scroll position remains the same (at the bottom of the apge)

What is the new behavior?

This change only restores the scroll position while navigating back.

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 0babbc4
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6861b9a807d2a400084f39a7

Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 0babbc4
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/6861b9a89bfede0008c0dbdd
😎 Deploy Preview https://deploy-preview-4850--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@markostanimirovic markostanimirovic merged commit 0ae48c3 into main Jun 29, 2025
14 checks passed
@markostanimirovic markostanimirovic deleted the docs/navigation branch June 29, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants