Skip to content

fix(www): add styles for video #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025

Conversation

shreykul
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Earlier, the thumbnail video was not showing properly in the centre and was smaller in size. I fixed the size and centred it using the css.

Closes #4848

What is the new behavior?

The iframe and thumbnail now appears in the centre and bigger in size than earlier.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Jun 27, 2025

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 8f84e32
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/685e62533df18a000897640c

Copy link

netlify bot commented Jun 27, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 8f84e32
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/685e625373c56600082d87de
😎 Deploy Preview https://deploy-preview-4851--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shreykul shreykul changed the title fix(www):adding styles for thumbnail(#4848) fix(www):adding styles for thumbnail Jun 27, 2025
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shreykul !

@markostanimirovic markostanimirovic changed the title fix(www):adding styles for thumbnail fix(www): add styles for video Jun 29, 2025
@markostanimirovic markostanimirovic merged commit 85680a0 into ngrx:main Jun 29, 2025
14 checks passed
@markostanimirovic
Copy link
Member

thanks @shreykul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Docs] Style thumbnail videos better
3 participants