Skip to content

fix(www): fix color-scheme and combine duplicate html declarations #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2025

Conversation

jdegand
Copy link
Contributor

@jdegand jdegand commented Jun 28, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Update styles in new docs. Also, there was a duplicate html block so I combined those styles into the initial html block.

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Color-scheme property is not properly set.

Closes #4854

What is the new behavior?

Default color-scheme is set.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link

netlify bot commented Jun 28, 2025

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3906fcf
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6861b56fc82a790008bc93aa
😎 Deploy Preview https://deploy-preview-4855--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jun 28, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 3906fcf
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/6861b56f4e10400008f98611
😎 Deploy Preview https://deploy-preview-4855--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@markostanimirovic markostanimirovic changed the title fix: color-scheme and combine duplicate html declarations fix(www): fix color-scheme and combine duplicate html declarations Jun 29, 2025
Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @jdegand!

@markostanimirovic markostanimirovic merged commit f9b2565 into ngrx:main Jun 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Docs]: color-scheme in styles.scss is wrong
3 participants