Skip to content

fix(signals): handle events in the dispatched order #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #4852

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

netlify bot commented Jun 29, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 73afc19
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/68618cdc81fcc80008f1a4bb

Copy link

netlify bot commented Jun 29, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 73afc19
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/68618cdc7fd1670008d843f9
😎 Deploy Preview https://deploy-preview-4857--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@markostanimirovic markostanimirovic marked this pull request as draft June 29, 2025 14:38
@markostanimirovic markostanimirovic marked this pull request as ready for review June 29, 2025 19:01
@timdeschryver timdeschryver merged commit fa50f43 into main Jun 30, 2025
14 checks passed
@timdeschryver timdeschryver deleted the fix/signals/events-dispatch-order branch June 30, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event effect returns cause initial event to be reduced after resulting event in event log reducer
3 participants