Skip to content

build: add wasm build action #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

build: add wasm build action #275

merged 2 commits into from
Jun 26, 2025

Conversation

legendecas
Copy link
Member

No description provided.

@legendecas legendecas force-pushed the ci branch 2 times, most recently from 21b0558 to 9e65311 Compare June 26, 2025 09:10
@legendecas legendecas changed the title build: fix permissions build: add wasm build action Jun 26, 2025
@legendecas legendecas marked this pull request as ready for review June 26, 2025 09:27
@marco-ippolito
Copy link
Member

why run on every PR?

@legendecas
Copy link
Member Author

@marco-ippolito changed to only run on deps/ and tools/ changes

@marco-ippolito
Copy link
Member

Actually I think this only needs to run if we change tools rather than deps. otherwise when we update it will rebuild again

@legendecas
Copy link
Member Author

I still think it is useful on changes on deps. The failures on #269 (comment) were not reflected on the PR. With this job, the failures will show up on the PR status.

@marco-ippolito marco-ippolito merged commit 4a90929 into nodejs:main Jun 26, 2025
9 checks passed
@legendecas legendecas deleted the ci branch June 26, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants