Skip to content

src: fix -Wreturn-stack-address error #58439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

codebytere
Copy link
Member

Refs #57016

Fixes the following:

../../third_party/electron_node/src/node_config_file.cc:26:16: error: returning address of local temporary object [-Werror,-Wreturn-stack-address]
   26 |         return it->substr(flag_path.size() + 1);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

@codebytere codebytere requested a review from marco-ippolito May 23, 2025 18:12
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (5ffcf6b) to head (3d0c700).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
src/node_config_file.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58439      +/-   ##
==========================================
- Coverage   90.22%   90.19%   -0.03%     
==========================================
  Files         635      635              
  Lines      187173   187224      +51     
  Branches    36747    36770      +23     
==========================================
  Hits       168870   168870              
- Misses      11071    11120      +49     
- Partials     7232     7234       +2     
Files with missing lines Coverage Δ
src/node_config_file.cc 73.38% <0.00%> (ø)

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@codebytere codebytere added the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2025
@nodejs-github-bot nodejs-github-bot merged commit 47081ee into nodejs:main May 28, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 47081ee

targos pushed a commit that referenced this pull request May 31, 2025
PR-URL: #58439
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
PR-URL: #58439
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants