-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
dns: support max timeout #58440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
dns: support max timeout #58440
Conversation
Review requested:
|
e1793dd
to
2a63e8c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58440 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.01%
==========================================
Files 636 636
Lines 187891 187905 +14
Branches 36878 36878
==========================================
+ Hits 169348 169356 +8
- Misses 11289 11293 +4
- Partials 7254 7256 +2
🚀 New features to boost your workflow:
|
2a63e8c
to
037237f
Compare
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - dns: support max timeout ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/15239866976 |
@@ -187,8 +195,8 @@ class ResolverBase { | |||
} | |||
|
|||
[kDeserializeResolver]() { | |||
const { timeout, tries, localAddress, servers } = this[kSnapshotStates]; | |||
this[kInitializeHandle](timeout, tries); | |||
const { timeout, tries, maxTimeout, localAddress, servers } = this[kSnapshotStates]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joyeecheung Hi ! Can I make a snapshot in node version 1 and then use it in version 2? Do I need to use maxTimeout=0 here ?
037237f
to
f260a95
Compare
f260a95
to
d10922a
Compare
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - dns: support max timeout ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/15520622792 |
When dns retries the query, the
tiemout
will keep increasing,max_timeout
caps thetimeout
.make -j4 test
(UNIX), orvcbuild test
(Windows) passes