Skip to content

dns: support max timeout #58440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dns: support max timeout #58440

wants to merge 1 commit into from

Conversation

theanarkh
Copy link
Contributor

When dns retries the query, the tiemout will keep increasing, max_timeout caps the timeout.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 23, 2025
@theanarkh theanarkh added semver-minor PRs that contain new features and should be released in the next minor version. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. and removed c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 23, 2025
@theanarkh theanarkh force-pushed the support_max_timeout_for_dns branch from e1793dd to 2a63e8c Compare May 23, 2025 19:08
@codecov Codecov
Copy link

codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (3c351c2) to head (d10922a).
Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
src/cares_wrap.cc 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58440      +/-   ##
==========================================
- Coverage   90.13%   90.12%   -0.01%     
==========================================
  Files         636      636              
  Lines      187891   187905      +14     
  Branches    36878    36878              
==========================================
+ Hits       169348   169356       +8     
- Misses      11289    11293       +4     
- Partials     7254     7256       +2
Files with missing lines Coverage Δ
lib/internal/dns/utils.js 99.46% <100.00%> (+0.01%) ⬆️
src/cares_wrap.h 78.97% <ø> (ø)
src/cares_wrap.cc 54.51% <81.81%> (+0.12%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lpinca
lpinca approved these changes May 24, 2025
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67039/

@theanarkh theanarkh force-pushed the support_max_timeout_for_dns branch from 2a63e8c to 037237f Compare May 25, 2025 09:57
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - dns: support max timeout
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/15239866976

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67081/

theanarkh
theanarkh commented Jun 3, 2025
View reviewed changes
lib/internal/dns/utils.js
@@ -187,8 +195,8 @@ class ResolverBase {
}

[kDeserializeResolver]() {
const { timeout, tries, localAddress, servers } = this[kSnapshotStates];
this[kInitializeHandle](timeout, tries);
const { timeout, tries, maxTimeout, localAddress, servers } = this[kSnapshotStates];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joyeecheung Hi ! Can I make a snapshot in node version 1 and then use it in version 2? Do I need to use maxTimeout=0 here ?

@theanarkh theanarkh force-pushed the support_max_timeout_for_dns branch from 037237f to f260a95 Compare June 7, 2025 16:57
@theanarkh theanarkh force-pushed the support_max_timeout_for_dns branch from f260a95 to d10922a Compare June 7, 2025 17:02
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2025

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - dns: support max timeout
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/15520622792

@theanarkh theanarkh added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theanarkh @nodejs-github-bot @lpinca