doc: graduate Symbol.dispose/asyncDispose from experimental #58467

jasnell · 2025-05-26T15:56:17Z

Now that Symbol.dispose and Symbol.asyncDispose have been enabled by default and are expected to likely advance to stage 4 this week, let's graduate them from experimental status.

nodejs-github-bot · 2025-05-26T15:56:22Z

Review requested:

@nodejs/http
@nodejs/http2
@nodejs/net
@nodejs/sqlite

doc/api/child_process.md

doc/api/dgram.md

doc/api/fs.md

doc/api/http.md

doc/api/http2.md

doc/api/https.md

doc/api/net.md

doc/api/sqlite.md

doc/api/stream.md

doc/api/timers.md

jasnell · 2025-05-26T16:00:27Z

Marking as don't land on anything before 24.x since it wasn't until 24.x that ERM was enabled by default.

legendecas · 2025-05-26T17:14:04Z

Should we wait for the proposal to be officially promoted to Stage 4 this week?

jasnell · 2025-05-26T17:40:21Z

We can, for sure. There's no rush to land this.

mcollina · 2025-05-26T17:56:19Z

Please wait for that.

legendecas · 2025-05-28T14:57:50Z

The proposal has confirmed to stage 4.

Now that Symbol.dispose and Symbol.asyncDispose have been enabled by default and are expected to likely advance to stage 4 this week, let's graduate them from experimental status. PR-URL: #58467 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

jasnell · 2025-05-28T16:51:44Z

Landed in ba6651a

Now that Symbol.dispose and Symbol.asyncDispose have been enabled by default and are expected to likely advance to stage 4 this week, let's graduate them from experimental status. PR-URL: #58467 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Notable changes: doc: * deprecate utilisNativeError in favor of ErrorisError (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate Symbol.dispose/asyncDispose from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add autoClose option to FileHandle readableWebStream (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635

Notable changes: doc: * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) #58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635

Notable changes: doc: * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) #58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635

Notable changes: doc: * add Filip Skokan to TSC (Rafael Gonzaga) nodejs#58499 * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) nodejs#58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) nodejs#58564 * deprecate HTTP/2 priority signaling (Matteo Collina) nodejs#58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) nodejs#58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) nodejs#57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) nodejs#58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) nodejs#58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) nodejs#58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) nodejs#58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) nodejs#58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) nodejs#58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) nodejs#58073 permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) nodejs#58579 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) nodejs#58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) nodejs#58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) nodejs#58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) nodejs#58385 PR-URL: nodejs#58635

doc: graduate Symbol.dispose/asyncDispose from experimental

cd8078e

Now that Symbol.dispose and Symbol.asyncDispose have been enabled by default and are expected to likely advance to stage 4 this week, let's graduate them from experimental status.

jasnell added the semver-minor label May 26, 2025

nodejs-github-bot added the doc label May 26, 2025