Skip to content

src: remove deprecated process exit APIs in node.h #58469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

legendecas
Copy link
Member

The APIs have been deprecated for 5 years.

Refs: #35486

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 26, 2025
@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 26, 2025
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (83052ff) to head (776c3b0).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58469      +/-   ##
==========================================
- Coverage   90.22%   90.20%   -0.02%     
==========================================
  Files         635      635              
  Lines      187313   187306       -7     
  Branches    36778    36786       +8     
==========================================
- Hits       169003   168968      -35     
- Misses      11080    11097      +17     
- Partials     7230     7241      +11     
Files with missing lines Coverage Δ
src/api/hooks.cc 88.80% <ø> (+4.40%) ⬆️
src/node.h 92.30% <ø> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2025
@nodejs-github-bot
Copy link
Collaborator

@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2025
@legendecas
Copy link
Member Author

Can this get another review from @nodejs/tsc as semver-major? Thank you!

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2025
@nodejs-github-bot nodejs-github-bot merged commit 56989d3 into nodejs:main May 29, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 56989d3

@legendecas legendecas deleted the node-h-legacy branch May 29, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants