src: remove deprecated process exit APIs in node.h #58469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
juanarbol
approved these changes
May 26, 2025
targos
added
the
semver-major
jasnell
approved these changes
May 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58469 +/- ##
==========================================
- Coverage 90.22% 90.20% -0.02%
==========================================
Files 635 635
Lines 187313 187306 -7
Branches 36778 36786 +8
==========================================
- Hits 169003 168968 -35
- Misses 11080 11097 +17
- Partials 7230 7241 +11
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
May 26, 2025
daeyeon
approved these changes
May 27, 2025
daeyeon
added
the
author ready
addaleax
approved these changes
May 27, 2025
|
Can this get another review from @nodejs/tsc as semver-major? Thank you! |
marco-ippolito
approved these changes
May 29, 2025
targos
approved these changes
May 29, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 56989d3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APIs have been deprecated for 5 years.
Refs: #35486