Skip to content

src: remove deprecated initialization APIs in node.h #58470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

src: remove deprecated initialization APIs in node.h #58470

wants to merge 2 commits into from
+16 −65

Conversation

legendecas
Copy link
Member

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 26, 2025
@legendecas legendecas added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label May 26, 2025
@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 26, 2025
@codecov Codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (83052ff) to head (2c44a67).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58470      +/-   ##
==========================================
- Coverage   90.22%   90.21%   -0.01%     
==========================================
  Files         635      635              
  Lines      187313   187299      -14     
  Branches    36778    36783       +5     
==========================================
- Hits       169003   168980      -23     
- Misses      11080    11081       +1     
- Partials     7230     7238       +8
Files with missing lines Coverage Δ
src/api/environment.cc 76.70% <ø> (+1.52%) ⬆️
src/node.cc 74.65% <ø> (+1.27%) ⬆️
src/node.h 92.30% <ø> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67111/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67139/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67164/

@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 28, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2025
@nodejs-github-bot
Copy link
Collaborator

Landed in ba6651a...d429aa2

nodejs-github-bot pushed a commit that referenced this pull request May 28, 2025
@legendecas @nodejs-github-bot
src: remove deprecated node::InitializeNodeWithArgs
e0ae14c 
PR-URL: #58470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot pushed a commit that referenced this pull request May 28, 2025
@legendecas @nodejs-github-bot
src: remove deprecated node::CreatePlatform and node::FreePlatform
d429aa2 
PR-URL: #58470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@legendecas legendecas deleted the node-h-init branch May 29, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@anonrig anonrig

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legendecas @nodejs-github-bot @jasnell @addaleax @anonrig @targos