-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(test): replace cloudflare open-next build test with playwright tests #7782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the GitHub workflow that verifies the Cloudflare open-next build with a new workflow that runs Playwright tests to validate the build.
- Updated Playwright configuration to support dynamic web server setup via environment variables.
- Replaced the Cloudflare worker build test with a Playwright test workflow that includes caching, browser installation, and report upload.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
apps/site/playwright.config.ts | Updated Playwright configuration including conditional web server launch and dynamic baseURL setup. |
.github/workflows/playwright-cloudflare-open-next.yml | Replaced the Cloudflare build job with a Playwright testing job along with concurrency and caching improvements. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7782 +/- ##
=======================================
Coverage 75.35% 75.36%
=======================================
Files 96 96
Lines 7861 7862 +1
Branches 192 192
=======================================
+ Hits 5924 5925 +1
Misses 1936 1936
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…right tests simplify logic as suggested
…right tests update forgotten env variable name in playwright.yml
…right tests still accept VERCEL_PREVIEW_URL to make PR go green
…right tests remove VERCEL_PREVIEW_URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
…right tests avoid running a script taken from process.env
…right tests add new getWebServerConfig function instead of using a ternary
Lighthouse Results
|
Description
Replaces the github workflow checking that the Cloudflare open-next build process works on PRs and pushes to main with a workflow that runs and checks the open-next build using playwright (built on top of the changes introduced in #7749)
Validation
I've validated this change by pushing this onto my fork's main branch and you can see the workflow working as expected there by checking the action runs (example)
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.