Skip to content

chore(ci): only run when certain files are changed #7783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

avivkeller
Copy link
Member

Using the push event helps prevent this workflow from running unnecessarily. It won’t change the publishing frequency, but ensures the workflow only runs when there’s actually something to publish: rather than empty matrix generation and related errors.

@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 17:58
@avivkeller avivkeller requested a review from a team as a code owner May 27, 2025 17:58
Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 27, 2025 5:58pm

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (d122e58) to head (8908909).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7783      +/-   ##
==========================================
- Coverage   75.35%   75.32%   -0.04%     
==========================================
  Files          96       96              
  Lines        7861     7861              
  Branches      192      192              
==========================================
- Hits         5924     5921       -3     
- Misses       1936     1939       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@avivkeller
Copy link
Member Author

@nodejs/web-infra PTAL

Copy link
Contributor

github-actions bot commented May 29, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit fefbf49 May 29, 2025
19 checks passed
@avivkeller avivkeller deleted the avivkeller-patch-1 branch May 29, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants