feat(angular-rspack): Add "zoneless" option to enable Angular's provideZonelessChangeDetection() usage
#115
Conversation
| @@ -265,6 +265,7 @@ export async function normalizeOptions( | |||
| vendorChunk: options.vendorChunk ?? false, | |||
| verbose: options.verbose ?? false, | |||
| watch: options.watch ?? false, | |||
| zoneless: options.zoneless ?? false, | |||
There was a problem hiding this comment.
suggestion: I'm questioning a bit the requirement of a dedicated config option for zoneless support, as
- running zoneless actually could be inferred by the absence of 'zone.js' in the
polyfillsconfig option - additionally, based on your changes it seems to only affect SSR respectively pre-rendering. So if a dedicated config option would really be a requirement, maybe it fits better to add it to
ssrorprerender?
There was a problem hiding this comment.
running zoneless actually could be inferred by the absence of 'zone.js' in the polyfillsconfig option
That'd be better I think; wasn't sure If such implicit behaviour might be breaking, or not. I guess it will do a lot more good, then bad.
Will make this change, thanks for review.
|
View your CI Pipeline Execution ↗ for commit 43881d7. ☁️ Nx Cloud last updated this comment at |
|
Hey @Chlebamaticon ! Thanks for the PR, this is great 🎉 Can you rebase this on top of |
…lization within PrerenderPlugin
Chlebamaticon
force-pushed
the
add-zoneless-support
branch
from
43881d7 to
9a65547
Compare
|
Rebased and lockfile resolved! 🙌 |
Added
"zoneless"property toAngularRspackPluginOptions, soPrerenderPluginis capable of skipping "zone.js" initialisation.I tried using rspack to build my Angular SSR application without "zone.js" and
PrerenderPlugindid complain about missing dependency.Suggestion