Skip to content

fix(testing): do not update component configuration in cypress set-inject-document-domain migration #31614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

The set-inject-document-domain migration updates the component configuration. This is incorrect since the inject-document-domain is not a property supported by the component configuration.

Expected Behavior

The set-inject-document-domain migration should not update the component configuration.

Related Issue(s)

Fixes #31610

@leosvelperez leosvelperez self-assigned this Jun 17, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner June 17, 2025 08:09
Copy link

vercel bot commented Jun 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 17, 2025 8:09am

Copy link

nx-cloud bot commented Jun 17, 2025

View your CI Pipeline Execution ↗ for commit 3dd4255.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 33m 58s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 17s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 2s View ↗
nx documentation ✅ Succeeded 3m 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 08:52:51 UTC

@FrozenPandaz FrozenPandaz merged commit 617b8d4 into master Jun 20, 2025
8 checks passed
@FrozenPandaz FrozenPandaz deleted the cypress/fix-set-inject-document-domain-migration branch June 20, 2025 13:45
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/cypress migration adds injectDocumentDomain to component configuration
2 participants