-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(js): deprecate simpleName option in library generator #31673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add x-deprecated to schema.json marking for removal in Nx 22 - Add runtime warning when simpleName is used - Update description to recommend providing exact name instead The simpleName option is no longer useful as we've moved to using options "as provided" without transformation. Users should provide the exact name, directory, and import path they want to use. Fixes #29508 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit a4a849d.
☁️ Nx Cloud last updated this comment at |
a98661d
to
3357ba4
Compare
✅ Clarified
|
- Add x-deprecated to schema.json marking for removal in Nx 22 - Add runtime warning when simpleName is used - Update description to recommend using --name option instead The simpleName option is no longer useful as we've moved to using options "as provided" without transformation. Users should use the --name option to provide the exact name, directory, and import path they want. Related to #29508 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
b7b793f
to
a4a849d
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
The simpleName option is no longer useful as we've moved to using options "as provided" without transformation. Users should provide the exact name, directory, and import path they want to use.
Changes
🤖 Generated with Claude Code
Current Behavior
Users are confused with
--simpleName
with using--name
AND--directory
Expected Behavior
We should tell users that only
--name
should be used.Related Issue(s)
Fixes #29508