nx release version does not propagate changes to release groups with "projectsRelationship": "independent" #31722
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit df99922.
Nx Cloud AI FixNx Cloud AI analyzes your failing CI tasks and automatically generates fixes whenever possible.
☁️ Nx Cloud last updated this comment at |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| >; | ||
| for (const [, { logs }] of projectLogger) { | ||
| const uniqueLogs = new Set(logs); | ||
| expect(logs.sort()).toEqual(Array.from(uniqueLogs).sort()); |
There was a problem hiding this comment.
The current assertion will always pass when there are duplicates because logs.sort() preserves duplicates while Array.from(uniqueLogs).sort() removes them. For example:
// If logs = ['a', 'a', 'b']
logs.sort() // ['a', 'a', 'b']
Array.from(uniqueLogs).sort() // ['a', 'b']These arrays would not be equal, but the test would still pass because .toEqual() is comparing the arrays after sorting both sides.
To properly verify there are no duplicates, consider changing to:
expect(logs.length).toEqual(uniqueLogs.size);This directly checks that the number of log entries equals the number of unique entries.
| expect(logs.sort()).toEqual(Array.from(uniqueLogs).sort()); | |
| expect(logs.length).toEqual(uniqueLogs.size); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
… with projectsRelationship independent
mpsanchis
force-pushed
the
failing-tests-nx-release
branch
from
b6e8371 to
df99922
Compare
mpsanchis
changed the title
|
@mpsanchis and I are discussing this, assigned myself |
Test that shows the problem mentioned in #31724