Skip to content

fix(core): improve error handling in daemon server #31728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jun 25, 2025

Current Behavior

When a message handler in the Daemon server throws an error, the process exits, and nothing is printed to the terminal.

Expected Behavior

Errors thrown by message handlers in the Daemon server should be handled appropriately and printed to the output.

Related Issue(s)

Fixes #31407
Fixes #31567

@leosvelperez leosvelperez self-assigned this Jun 25, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner June 25, 2025 12:36
@leosvelperez leosvelperez requested a review from AgentEnder June 25, 2025 12:36
Copy link

vercel bot commented Jun 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 25, 2025 1:06pm

Copy link
Contributor

nx-cloud bot commented Jun 25, 2025

View your CI Pipeline Execution ↗ for commit 158cf28.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 30m 14s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 2m 25s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-25 13:23:18 UTC

@leosvelperez leosvelperez force-pushed the core/daemon-server-handle-errors branch from 36120a5 to 21903dd Compare June 25, 2025 12:41
@leosvelperez leosvelperez merged commit 768a11a into master Jun 26, 2025
8 checks passed
@leosvelperez leosvelperez deleted the core/daemon-server-handle-errors branch June 26, 2025 13:44
Copy link

github-actions bot commented Jul 2, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx throws silent error on latest nx with nest preset in WS2 Bun CLI Output Problem with Some Bundlers (tsc, rollup, vite)
2 participants