fix(angular): respect skipTsConfig option in library generator #31738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue where the Angular library generator ignored the skipTsConfig option. When skipTsConfig=true, the tsconfig.base.json file is no longer modified. Project-specific tsconfig files are still created as expected. Closes #31185
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit aff479a.
☁️ Nx Cloud last updated this comment at |
leosvelperez
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The Angular library generator ignores the
skipTsConfigoption and always modifies thetsconfig.base.jsonfile, even when users explicitly setskipTsConfig=trueto avoid TypeScript configuration changes.Expected Behavior
When
skipTsConfig=trueis passed to the Angular library generator, thetsconfig.base.jsonfile should not be modified. Project-specific tsconfig files should still be created as expected, but the workspace-level TypeScriptconfiguration should remain untouched.
Related Issue(s)
Fixes #31185