fix(vite): resolve outDir path correctly for nested monorepos #31741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace naive string manipulation with proper Node.js path resolution to fix output directory calculation in nested monorepo structures.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 06b4a58.
☁️ Nx Cloud last updated this comment at |
leosvelperez
approved these changes
Jun 26, 2025
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The Vite build executor uses naive string manipulation to calculate the output directory path, which fails in nested monorepo structures where the workspace root and project root have different relative paths.
Expected Behavior
The Vite build executor properly resolves the output directory path using Node.js path utilities, ensuring correct path calculation regardless of monorepo nesting structure.
Related Issue(s)
Fixes #31234