Skip to content

fix(testing): correct Playwright grep documentation from glob to regex #31743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jun 26, 2025

  • Fixed documentation to clarify grep uses regex not glob patterns
  • Updated examples to show proper regex usage
  • Corrected both --grep and --grepInvert documentation

Fixes #30181

- Fixed documentation to clarify grep uses regex not glob patterns
- Updated examples to show proper regex usage
- Corrected both --grep and --grepInvert documentation

Fixes #30181
@jaysoo jaysoo requested review from a team as code owners June 26, 2025 12:38
@jaysoo jaysoo requested a review from leosvelperez June 26, 2025 12:38
Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 26, 2025 0:38am

Copy link

nx-cloud bot commented Jun 26, 2025

View your CI Pipeline Execution ↗ for commit ac9bb8c.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 4m 16s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 11s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 3s View ↗
nx documentation ✅ Succeeded 33s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-26 12:48:56 UTC

@jaysoo jaysoo merged commit 57405e6 into master Jun 26, 2025
9 checks passed
@jaysoo jaysoo deleted the fix/issue-30181 branch June 26, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playwright grep docs using glob not regex
3 participants