Skip to content

Add support for allowNegative ("--no-foo") #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bakkot
Copy link
Collaborator

@bakkot bakkot commented Jun 27, 2025

Fixes #160; cc @ljharb.

Direct port of nodejs/node#53107. Node is MIT licensed, same as this project, so that should be kosher. I added the original author as a coauthor on the commit.

Co-authored-by: Zhenwei Jin <109658203+kylo5aby@users.noreply.github.com>
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Confirmed it matches the node commit.

@ljharb ljharb requested a review from shadowspawn June 27, 2025 05:26
@bakkot
Copy link
Collaborator Author

bakkot commented Jun 27, 2025

oh, should update the readme too I guess

edit: done

Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bakkot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to implement allowNegative option
3 participants