Skip to content

Fix ParseResultBytes when we have a valid IRI #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Conversation

sigmavirus24
Copy link
Collaborator

Closes #57

Verified

This commit was signed with the committer’s verified signature.
sigmavirus24 Ian Stapleton Cordasco
Closes #57
@sigmavirus24
Copy link
Collaborator Author

I don't like this but it works. I'll probably take another pass at this tomorrow to see if I can find a more correct solution

@sigmavirus24
Copy link
Collaborator Author

Some of the problems we have are:

  1. We can rely on IRIReference because it depends on the optional idna package being installed
  2. If we do "https://i❤.ws".encode('idna').decode('idna') we get the same thing back and then our URIReference thinks that i❤.ws is invalid so it generates the URI in the issue that's wrong

@sigmavirus24
Copy link
Collaborator Author

I'm struggling to figure out a better way to handle this. Maybe I'll revisit this in the future

@sigmavirus24 sigmavirus24 merged commit 1ca99c9 into master Apr 9, 2020
@sigmavirus24 sigmavirus24 deleted the bug/57 branch April 9, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geturl() of the ParseResultBytes can't get correct url
1 participant