Match empty path without using line begin/end #96
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows correclty recognizing URIs with a scheme, but no authority and an empty path (and possibly non-empty query or fragment) as absolute. The "about:" URI scheme is a scheme that allows such syntax. This uses a non-capturing group as it was unclear if any code anywhere else was relying on capture group numbering from regexes that include the empty path regex.
|
Also, I'm assuming nothing was relying on the line begin/end since everything still passes, but do please let me know if I'm missing something. |
|
On further thought it seems like this syntax is not legal at all. Closing this PR unless/until there's a definitive judgement that it's needed in the linked issue. |
|
I confused myself, and I think I have now unconfused myself and this PR is actually relevant after all. Apologies for the noise. |
sigmavirus24
approved these changes
Feb 21, 2023
|
Thank you! No need to apologize for the noise, didn't notice it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88: This change allows correctly recognizing URIs with a scheme, but no authority and an empty path (and possibly non-empty query or fragment) as absolute. The "about:" URI scheme is a scheme that allows such syntax, as show in the linked issue.
This uses a non-capturing group as it was unclear if any code anywhere else was relying on capture group numbering from regexes that include the empty path regex. I'm happy to change it if anyone has a better idea.