gh-135773: have pyvenv.cfg without home key anchor a venv and deduce home #135831
+25
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing.venv.home
27 tasks
|
Hi all, With ncoghlan's sponsorship, I've written a PEP to formalize relative home path behavior for 3.15 and later. It's been assigned as PEP 796 and is awaiting PEP editor review before being posted for discussion. Is this sufficient progress to make people comfortable approving this PR and applying to 3.14? If not, is there additional work that would? |
ncoghlan
added
3.14
ncoghlan
approved these changes
Jul 4, 2025
|
Thanks @rickeylev for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 4, 2025
…educe home (pythonGH-135831) This is still formally undefined behaviour, but we may as well keep the *same* undefined behaviour as previous versions. PEP 796 proposes a cleaner and more consistent replacement for 3.15+ (cherry picked from commit 93263d43141a81d369adfcddf325f9a54cb5766d) Co-authored-by: Richard Levasseur <rlevasseur@google.com>
|
GH-136287 is a backport of this pull request to the 3.14 branch. |
ncoghlan
pushed a commit
that referenced
this pull request
Jul 4, 2025
…deduce home (GH-135831) (#136287) gh-135773: have pyvenv.cfg without home key anchor a venv and deduce home (GH-135831) This is still formally undefined behaviour, but we may as well keep the *same* undefined behaviour as previous versions. PEP 796 proposes a cleaner and more consistent replacement for 3.15+ (cherry picked from commit 93263d4) Co-authored-by: Richard Levasseur <rlevasseur@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the 3.13 behavior where pyvenv.cfg without a home key still activates
a virtual environment. In such cases, home is typically found by reading the symlink
that venv's interpreter executable points to.