Skip to content

gh-135885: Fix undocumented method CookieJar.clear_expired_cookies in lib http.cookiejar #135882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LamentXU123
Copy link
Contributor

@LamentXU123 LamentXU123 commented Jun 24, 2025

Although there is low possibility to call this method if you are using DefaultCookiePolicy, but as a method of CookieJar that could be used(do not start with _, and would be used when users are customizing their own policies), the method is supposed to be documented.


📚 Documentation preview 📚: https://cpython-previews--135882.org.readthedocs.build/

@LamentXU123
Copy link
Contributor Author

sorry for clinking the wrong button.

@picnixz
Copy link
Member

picnixz commented Jun 24, 2025

Pleae open an issue. Adding docs should still have an issue.

@bedevere-app
Copy link

bedevere-app bot commented Jun 24, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@LamentXU123
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jun 24, 2025

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from picnixz June 24, 2025 11:28
@LamentXU123 LamentXU123 changed the title Fix undocumented method CookieJar.clear_expired_cookies in lib http.cookiejar gh-135885: Fix undocumented method CookieJar.clear_expired_cookies in lib http.cookiejar Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants