-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-135906: Use _PyObject_CAST in internal CPython headers #135892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Please open an issue in this tracker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a blurb entry, per the bot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some similar issues elsewhere:
PyObject *op = _PyFreeList_PopNoStats(fl); |
cpython/Include/internal/pycore_weakref.h
Line 63 in 642e5df
PyObject *obj = FT_ATOMIC_LOAD_PTR(ref->wr_object); |
cpython/Include/internal/pycore_weakref.h
Line 90 in 642e5df
PyObject *obj = FT_ATOMIC_LOAD_PTR(ref->wr_object); |
Theoretically, we could test for this by including internal headers in test_cppext, but I haven't decided whether I think that's a good idea yet. I'm worried that we're going to be encouraging people to use the private API. Which APIs does Greenlet need?
Misc/NEWS.d/next/C_API/2025-06-25-01-03-10.gh-issue-135906.UBrCWq.rst
Outdated
Show resolved
Hide resolved
…CWq.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This: |
Ok. For 3.15, please open an issue requesting that those private APIs be exposed as unstable APIs. |
They don't need to open a new issue. This is a known issue with Cython reporting it as well #130931 |
I would be happy to merge this (I won't block it). However, we should have some way to make sure we don't regress. |
I think including |
Fixes build errors encountered in python-greenlet/greenlet#450 when building greenlet against CPython 3.14.0b3 free-threaded. Resolves #135906