gh-91555: add warning to docs about possibility of deadlock/infinite recursion #135954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inite recursion Attempt to clarify in the documentation that care must be taken when using multiprocessing classes to implement logging since they have builtin internal logging, and hence may cause deadlock/infinite recursion.
bedevere-app
bot
added
awaiting review
docs
vsajip
requested changes
Jun 26, 2025
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
vsajip
reviewed
Jun 26, 2025
vsajip
approved these changes
Jun 26, 2025
vsajip
added
needs backport to 3.13
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2025
…inite recursion (pythonGH-135954) * pythongh-91555: add warning to docs about possibility of deadlock/infinite recursion Attempt to clarify in the documentation that care must be taken when using multiprocessing classes to implement logging since they have builtin internal logging, and hence may cause deadlock/infinite recursion. * Update Doc/library/logging.handlers.rst Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk> * Change whitespace. --------- (cherry picked from commit a4625d5) Co-authored-by: Duane Griffin <duaneg@dghda.com> Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2025
…inite recursion (pythonGH-135954) * pythongh-91555: add warning to docs about possibility of deadlock/infinite recursion Attempt to clarify in the documentation that care must be taken when using multiprocessing classes to implement logging since they have builtin internal logging, and hence may cause deadlock/infinite recursion. * Update Doc/library/logging.handlers.rst Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk> * Change whitespace. --------- (cherry picked from commit a4625d5) Co-authored-by: Duane Griffin <duaneg@dghda.com> Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
|
GH-135988 is a backport of this pull request to the 3.14 branch. |
|
GH-135989 is a backport of this pull request to the 3.13 branch. |
vsajip
pushed a commit
that referenced
this pull request
Jun 26, 2025
vsajip
pushed a commit
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to clarify in the documentation that care must be taken when using multiprocessing classes to implement logging since they have builtin internal logging, and hence may cause deadlock/infinite recursion.
📚 Documentation preview 📚: https://cpython-previews--135954.org.readthedocs.build/