-
Notifications
You must be signed in to change notification settings - Fork 6.6k
[Docs] Add image tag to rayproject/ray-ml
#53854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Cheyu Wu <cheyu1220@gmail.com>
rayproject/ray-ml
@@ -50,7 +50,7 @@ the second `mobilenet` is the name of the Python file in the directory `mobilene | |||
helm uninstall raycluster | |||
|
|||
# Install the RayCluster CR with the Ray image `rayproject/ray-ml:${RAY_VERSION}` | |||
helm install raycluster kuberay/ray-cluster --version 1.3.0 --set image.repository=rayproject/ray-ml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not do this. It may cause differences in the Ray version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about removing Step 5 and using runtime env + UV (you should use KubeRay v1.4 RayCluster Helm chart) instead?
Signed-off-by: Cheyu Wu <cheyu1220@gmail.com>
Hi @kevin85421, I have changed to UV and runtime env, PTAL |
@@ -43,26 +43,28 @@ serve run mobilenet.mobilenet:app | |||
* `serve run mobilenet.mobilenet:app`: The first `mobilenet` is the name of the directory in the `serve_config_examples/`, | |||
the second `mobilenet` is the name of the Python file in the directory `mobilenet/`, and `app` is the name of the variable representing Ray Serve application within the Python file. See the section "import_path" in [rayservice-troubleshooting.md](kuberay-raysvc-troubleshoot) for more details. | |||
|
|||
# Step 5: Change the Ray image from `rayproject/ray:${RAY_VERSION}` to `rayproject/ray-ml:${RAY_VERSION}` | |||
# Step 5: Use the UV Environment to Install Required Packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do you enable the UV feature gate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, I just took another look at this release.
I made a mistake earlier — I thought version 2.46.0
had already set RAY_RUNTIME_ENV_HOOK
by default.
I'll go ahead and make the necessary changes on my end.
# Launch the Ray Serve application with runtime environment. | ||
serve run mobilenet.mobilenet:app --runtime-env-json='{"pip": ["python-multipart==0.0.6"]}' | ||
# Launch the Ray Serve application with the updated runtime environment | ||
uv run -- serve run mobilenet.mobilenet:app --runtime-env-json '{"pip": ["tensorflow==2.19.0", "pillow", "python-multipart==0.0.6"]}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have already used uv, do we still need runtime-env-json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added runtime-env-json
because I encountered an issue where the worker would run into a runtime error due to missing some packages.
I am not sure it's relative to uv feature gate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, after a few tries, I think this is not necessary. I will remove this
After offline sync, we decide to close this pr. |
Why are these changes needed?
When I followed the steps up to this part, I encountered an
ErrImagePull error
. After describing the head pod, I found the reason was that the image docker.io/rayproject/ray-ml:2.41.0 could not be found.Then I checked rayproject/ray-ml and confirmed that there is no
2.41.0
tag—only tags like2.41.0.021baf
. So I updated the tag to use thelatest
available one instead.Manual testing
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.