Skip to content

[Docs] Add image tag to rayproject/ray-ml #53854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

CheyuWu
Copy link
Contributor

@CheyuWu CheyuWu commented Jun 16, 2025

Why are these changes needed?

When I followed the steps up to this part, I encountered an ErrImagePull error. After describing the head pod, I found the reason was that the image docker.io/rayproject/ray-ml:2.41.0 could not be found.

Then I checked rayproject/ray-ml and confirmed that there is no 2.41.0 tag—only tags like 2.41.0.021baf. So I updated the tag to use the latest available one instead.

Manual testing

$ helm install raycluster kuberay/ray-cluster --version 1.3.0 --set image.repository=rayproject/ray-ml,image.tag=latest

image

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@CheyuWu CheyuWu requested review from pcmoritz, kevin85421 and a team as code owners June 16, 2025 17:17
Signed-off-by: Cheyu Wu <cheyu1220@gmail.com>
@CheyuWu CheyuWu changed the title [Docs] Add image tag to rayproject/ray-ml [Docs] Add image tag to rayproject/ray-ml Jun 16, 2025
@@ -50,7 +50,7 @@ the second `mobilenet` is the name of the Python file in the directory `mobilene
helm uninstall raycluster

# Install the RayCluster CR with the Ray image `rayproject/ray-ml:${RAY_VERSION}`
helm install raycluster kuberay/ray-cluster --version 1.3.0 --set image.repository=rayproject/ray-ml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not do this. It may cause differences in the Ray version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing Step 5 and using runtime env + UV (you should use KubeRay v1.4 RayCluster Helm chart) instead?

Signed-off-by: Cheyu Wu <cheyu1220@gmail.com>
@CheyuWu
Copy link
Contributor Author

CheyuWu commented Jun 22, 2025

Hi @kevin85421, I have changed to UV and runtime env, PTAL

@@ -43,26 +43,28 @@ serve run mobilenet.mobilenet:app
* `serve run mobilenet.mobilenet:app`: The first `mobilenet` is the name of the directory in the `serve_config_examples/`,
the second `mobilenet` is the name of the Python file in the directory `mobilenet/`, and `app` is the name of the variable representing Ray Serve application within the Python file. See the section "import_path" in [rayservice-troubleshooting.md](kuberay-raysvc-troubleshoot) for more details.

# Step 5: Change the Ray image from `rayproject/ray:${RAY_VERSION}` to `rayproject/ray-ml:${RAY_VERSION}`
# Step 5: Use the UV Environment to Install Required Packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do you enable the UV feature gate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, I just took another look at this release.
I made a mistake earlier — I thought version 2.46.0 had already set RAY_RUNTIME_ENV_HOOK by default.
I'll go ahead and make the necessary changes on my end.

# Launch the Ray Serve application with runtime environment.
serve run mobilenet.mobilenet:app --runtime-env-json='{"pip": ["python-multipart==0.0.6"]}'
# Launch the Ray Serve application with the updated runtime environment
uv run -- serve run mobilenet.mobilenet:app --runtime-env-json '{"pip": ["tensorflow==2.19.0", "pillow", "python-multipart==0.0.6"]}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have already used uv, do we still need runtime-env-json?

Copy link
Contributor Author

@CheyuWu CheyuWu Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added runtime-env-json because I encountered an issue where the worker would run into a runtime error due to missing some packages.
I am not sure it's relative to uv feature gate

Copy link
Contributor Author

@CheyuWu CheyuWu Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, after a few tries, I think this is not necessary. I will remove this

@CheyuWu
Copy link
Contributor Author

CheyuWu commented Jun 24, 2025

After offline sync, we decide to close this pr.

@CheyuWu CheyuWu closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants