Skip to content

[dashboard] Support to overwrite the _client_max_size of http request entity #53880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

caican00
Copy link

@caican00 caican00 commented Jun 17, 2025

Why are these changes needed?

I think we should support adjusting the max size of the request entity in the upload_package in job_head, some packages can easily exceed the default limit of 1m.

Related issue number

#53879

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@dayshah dayshah self-assigned this Jun 17, 2025
@dayshah
Copy link
Contributor

dayshah commented Jun 17, 2025

looks like the test is failing?

caican00 added 3 commits June 18, 2025 09:43
… entity

Signed-off-by: caican00 <imcaican@gmail.com>
… entity

Signed-off-by: caican00 <imcaican@gmail.com>
… entity

Signed-off-by: caican00 <imcaican@gmail.com>
@caican00
Copy link
Author

looks like the test is failing?

Hi @dayshah, thanks for your reply, i will fix it.

Copy link

github-actions bot commented Jul 2, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jul 2, 2025
Copy link

This pull request has been automatically closed because there has been no more activity in the 14 days
since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!

@github-actions github-actions bot closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants