-
Notifications
You must be signed in to change notification settings - Fork 1k
Fastify V4->V5 Upgrade #12046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ladderschool
wants to merge
11
commits into
redwoodjs:main
Choose a base branch
from
ladderschool:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fastify V4->V5 Upgrade #12046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Jun 7, 2025
Huge shoutout to @ladderschool who originally created this PR over at the RedwoodGQL repo: redwoodjs/graphql#12046 V4 of Fastify is approaching end of life by 6/30/25. This PR seeks to upgrade the relevant packages. Fastify V5 also requires node >=20 now. Migration docs: https://fastify.dev/docs/latest/Guides/Migration-Guide-V5/ Luckily many changes were already deprecated from V3->V4 and I have found no issues running V5 in my production app. The only breaking change is how Fastify handles the logger, which this PR addresses, specifically in the [createServerHelpers.ts](https://github.com/redwoodjs/graphql/compare/main...ladderschool:redwood:main?expand=1#diff-2f9b7c2c7a03d2b1aca7d841ce3365a524a92b7bee07c5177272f1dbf1395d84) file. ```js // v5 const loggerInstance = require('pino')() const fastify = require('fastify')({ loggerInstance }) ``` There's a test repository that @ladderschool used to confirm these updates in this PR from: https://github.com/ladderschool/fastify-v5-test Local build succeeded: https://cloud.nx.app/runs/saVKz8Qhgn Local tests succeeded: https://cloud.nx.app/runs/5SujFvDgYM --------- Co-authored-by: ladderschool <ladderschooledu@gmail.com>
I think @Tobbe's implementation in CedarJS is probably more type safe and easier to maintain down the line:
|
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Jun 8, 2025
Huge shoutout to @ladderschool who originally created this PR over at the RedwoodGQL repo: redwoodjs/graphql#12046 V4 of Fastify is approaching end of life by 6/30/25. This PR seeks to upgrade the relevant packages. Fastify V5 also requires node >=20 now. Migration docs: https://fastify.dev/docs/latest/Guides/Migration-Guide-V5/ Luckily many changes were already deprecated from V3->V4 and I have found no issues running V5 in my production app. The only breaking change is how Fastify handles the logger, which this PR addresses, specifically in the [createServerHelpers.ts](https://github.com/redwoodjs/graphql/compare/main...ladderschool:redwood:main?expand=1#diff-2f9b7c2c7a03d2b1aca7d841ce3365a524a92b7bee07c5177272f1dbf1395d84) file. ```js // v5 const loggerInstance = require('pino')() const fastify = require('fastify')({ loggerInstance }) ``` There's a test repository that @ladderschool used to confirm these updates in this PR from: https://github.com/ladderschool/fastify-v5-test Local build succeeded: https://cloud.nx.app/runs/saVKz8Qhgn Local tests succeeded: https://cloud.nx.app/runs/5SujFvDgYM --------- Co-authored-by: ladderschool <ladderschooledu@gmail.com>
@ladderschool Do you want to update this PR to incorporate the improved implementation I have in CedarJS plus fixing the merge issues in yarn.lock, or are you happy to just use Cedar instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V4 of Fastify is approaching end of life by 6/30/25. This PR seeks to upgrade the relevant packages.
Fastify V5 also requires node>=20 now.
Migration docs:
https://fastify.dev/docs/latest/Guides/Migration-Guide-V5/
Luckily many changes were already deprecated from V3->V4 and I have found no issues running V5 in my production app. The only breaking change is how Fastify handles the logger, which this PR addresses, specifically in the createServerHelpers.ts file.
I have a test repository that I used to confirm these updates in this PR from:
https://github.com/ladderschool/fastify-v5-test
Local build succeeded: https://cloud.nx.app/runs/saVKz8Qhgn
Local tests succeeded: https://cloud.nx.app/runs/5SujFvDgYM
I did notice though that I had to change the imports to:
Could be a module resolution issue in tsconfig that I have? The Fastify docs don't mention anything in regards to that, though.