Skip to content

[Visual] Add colors to the output of times depending on the speed #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Pyxels
Copy link

@Pyxels Pyxels commented Dec 14, 2022

Don't know if this is something you'd like in your project, but I enjoy it. Feel free to close or critique, this is my first Rust PR.

This changes the color of the times outputted when running depending on the speed, to make it easiers to spot outliers and possible slow implementations. Since slow is subjective this feature disabled by default and I've added a command line flag -c or --color to enable the coloring.

Here are two screenshot with fast and slow solutions to illustrate the colors.
2022-12-14_15:58:33
2022-12-14_15:57:58

Copy link
Owner

@remi-dupre remi-dupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks for your PR, this look gorgeous!

NB: as I see you enjoy colorful output you might like the automatic submission / checks I have started implementing in #29 (I'll attempt to merge it this week-end)

image

@remi-dupre
Copy link
Owner

remi-dupre commented Dec 14, 2022

Also, I think you can be more proud of your submission and make this an opt-out instead of an opt-in (--no-color instead of --color), maybe using more dim colors will help making it not too aggressive 🤔

Pyxels and others added 2 commits December 14, 2022 18:45
@Pyxels
Copy link
Author

Pyxels commented Dec 14, 2022

I somewhat experimented with other color shades using .truecolor(r, g, b), but I found I quite liked the current colors. The current version with explicit colors also makes it easier to read for what that's worth.

If it's important I can look into it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants