Fix test for 32 bit architectures #18993
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ RUN ] TypeReflectionTest.GetSizeOfType
/builddir/build/BUILD/root-6.36.00-build/root-6.36.00/interpreter/CppInterOp/unittests/CppInterOp/TypeReflectionTest.cpp:79: Failure
Expected equality of these values:
Cpp::GetSizeOfType(Cpp::GetVariableType(Decls[4]))
Which is: 12
16
[ FAILED ] TypeReflectionTest.GetSizeOfType (23 ms)
[ RUN ] ScopeReflectionTest.SizeOf
/builddir/build/BUILD/root-6.36.00-build/root-6.36.00/interpreter/CppInterOp/unittests/CppInterOp/ScopeReflectionTest.cpp:161: Failure
Expected equality of these values:
Cpp::SizeOf(Decls[7])
Which is: 12
(size_t)16
Which is: 16
[ FAILED ] ScopeReflectionTest.SizeOf (26 ms)
|
This needs to be reviewed by @Vipul-Cariappa or @aaronj0. Maybe the same change should be applied upstream? |
Test Results 19 files 19 suites 3d 8h 2m 58s ⏱️ For more details on these failures, see this check. Results for commit 9efe32d. |
aaronj0
requested changes
Jun 8, 2025
| @@ -158,7 +158,7 @@ TEST(ScopeReflectionTest, SizeOf) { | |||
| EXPECT_EQ(Cpp::SizeOf(Decls[4]), (size_t)0); | |||
| EXPECT_EQ(Cpp::SizeOf(Decls[5]), (size_t)1); | |||
| EXPECT_EQ(Cpp::SizeOf(Decls[6]), (size_t)4); | |||
| EXPECT_EQ(Cpp::SizeOf(Decls[7]), (size_t)16); | |||
| EXPECT_EQ(Cpp::SizeOf(Decls[7]), (size_t) (sizeof(size_t) == 4 ? 12 : 16)); | |||
There was a problem hiding this comment.
Based on the CI failure, I believe we also need to account for 32-bit MSVC platforms since the double is 8-byte aligned.
Perhaps an approach like:
Suggested change
| EXPECT_EQ(Cpp::SizeOf(Decls[7]), (size_t) (sizeof(size_t) == 4 ? 12 : 16)); | |
| struct B {short a; double b;}; | |
| EXPECT_EQ(Cpp::SizeOf(Decls[7]), sizeof(B)); |
should always reflect the correct platform ABI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the struct isdifferent on 32 bit architectures.