Ignore warnings from uring IO #18994
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests randomly fail because the uring memory is exhausted. Here are some examples: [ RUN ] RNTuple.RandomAccess .../root-6.36.00/core/testsupport/src/TestSupport.cxx:79: Failure Failed Received unexpected diagnostic of severity 2000 at 'RIoUring' reading 'io_uring is unexpectedly not available because: Failed to allocate memory for the smallest possible io_uring instance. 'memlock' memory has been exhausted for this user'. Suppress those using ROOT/TestSupport.hxx .../root-6.36.00/core/testsupport/src/TestSupport.cxx:79: Failure Failed Received unexpected diagnostic of severity 2000 at 'RRawFileUnix' reading 'io_uring setup failed, falling back to blocking I/O in ReadV'. Suppress those using ROOT/TestSupport.hxx [ FAILED ] RNTuple.RandomAccess (20472 ms) [ RUN ] RNTupleDSTest.ChainMT .../root-6.34.08/core/testsupport/src/TestSupport.cxx:79: Failure Failed Received unexpected diagnostic of severity 2000 at 'RIoUring' reading 'io_uring is unexpectedly not available because: Failed to allocate memory for the smallest possible io_uring instance. 'memlock' memory has been exhausted for this user'. Suppress those using ROOT/TestSupport.hxx .../root-6.34.08/core/testsupport/src/TestSupport.cxx:79: Failure Failed Received unexpected diagnostic of severity 2000 at 'RRawFileUnix' reading 'io_uring setup failed, falling back to blocking I/O in ReadV'. Suppress those using ROOT/TestSupport.hxx [ FAILED ] RNTupleDSTest.ChainMT (1004 ms)
Test Results 19 files 19 suites 3d 13h 8m 55s ⏱️ For more details on these failures, see this check. Results for commit 1c0b441. |
hahnjo
reviewed
Jun 11, 2025
| @@ -76,6 +76,20 @@ static struct ForbidDiagnostics { | |||
| return; | |||
| } | |||
|
|
|||
| if (level == kWarning | |||
| && strcmp(location, "RIoUring") == 0 | |||
| && strcmp(msg, "io_uring is unexpectedly not available because:\nFailed to allocate memory for the smallest possible io_uring instance. 'memlock' memory has been exhausted for this user") == 0) { | |||
There was a problem hiding this comment.
I don't know if we only want to check a substring of the message. This would make the code shorter and also makes future mistakes less likely where we change a part of the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests randomly fail because the uring memory is exhausted.
Here are some examples: