Lift template requirement for TTree Snapshot #19006
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
requested review from
bellenot,
martamaja10 and
pcanal
as code owners
Test Results 18 files 18 suites 3d 7h 32m 47s ⏱️ Results for commit 29aac64. ♻️ This comment has been updated with latest results. |
vepadulano
force-pushed
the
rdf-untyped-snapshot
branch
3 times, most recently
from
3af9457 to
110f23f
Compare
These are the changes needed to avoid the requirement to call Snapshot to a TTree dataset with template arguments for the column types, or to JIT the call in case the template arguments are not given. Still missing: * Doing the same for RNTuple * Deprecating the Snapshot call with the argument type list
vepadulano
force-pushed
the
rdf-untyped-snapshot
branch
from
110f23f to
29aac64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes needed to avoid the requirement to call Snapshot to a TTree dataset with template arguments for the column types, or to JIT the call in case the template arguments are not given.
Still missing: