[tree] properly copy entry list, also queried indices #19036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 3d 8h 38m 15s ⏱️ Results for commit 87d6950. |
pcanal
reviewed
Jun 16, 2025
Comment on lines
+1267
to
+1268
| elist->fLastIndexQueried = fLastIndexQueried; | ||
| elist->fLastIndexReturned = fLastIndexReturned; |
There was a problem hiding this comment.
Most other places, we seem to be using:
Suggested change
| elist->fLastIndexQueried = fLastIndexQueried; | |
| elist->fLastIndexReturned = fLastIndexReturned; | |
| elist->fLastIndexQueried = -1; | |
| elist->fLastIndexReturned = 0; |
why is it different here? (especially since I am not sure whether LastIndex returns is likely to need to be expressed in local entry number)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes #13338
fyi @romainbqt
Checklist: