-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[tree] avoid resetting index in entry list copy constructor #19039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Could you add a test? |
Test Results 19 files 19 suites 3d 13h 4m 57s ⏱️ For more details on these failures, see this check. Results for commit 6ad61f8. ♻️ This comment has been updated with latest results. |
Test added. I am not sure if the failures are race condition or if it's breaking sth. |
Co-authored-by: Silverweed <7806878+silverweed@users.noreply.github.com>
fLastIndexQueried = elist.fLastIndexQueried; | ||
fLastIndexReturned = elist.fLastIndexReturned; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit surprising changing for the usual starting point to the previously visited entry fixes the problem. Those 2 data members are meant to be accelerator and so the default value should have been fine. ... What is the mechanism leading to the failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it was an empirical fix. Without this, the returned value is PreviousVisitedEntry + 1, so 16 even if Index is -1
It seems as if the variable index is -1 but the entry pointer is still at 15.
This Pull request:
Changes or fixes:
Fixes https://its.cern.ch/jira/browse/ROOT-10807
Checklist: