-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[roottest] set build dir when compile macro #19054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results 18 files 18 suites 3d 12h 38m 38s ⏱️ Results for commit 2920b72. ♻️ This comment has been updated with latest results. |
I am exactly sure why it works before and not after. The test failures seems to indicates that the ACLiCed library is being loaded both explicitly (as intended by the test) and implicitly (autoloading). It might be related to (before the rootmap file would not be copied, after the rootmap file would be built in the run-time/binary directory)
|
Most (all?) failures due to fact that both compiled and interpreted version of macro need to be running. To exclude interference - I will try to delete all libs first, then run interpreted version and finally run ACLiC version. |
9946d02
to
08be0da
Compare
12ee70e
to
698f472
Compare
Try to create many temporary files in source directory where macro is situated. Most significant draw back has on Windows when several files has to be moved or deleted from source directory
Remove macro dll to avoid interfearence with interpreted and compiled macro
re-enable runtemplateMembers.C
Clarify dependencies for ctest
698f472
to
5128a13
Compare
On the Windows one should compile macro before running it. Doing same on other platforms fails. Change test names to avoid collision in log files Remove unused files
5128a13
to
2920b72
Compare
@pcanal After fixing dependency new approach works |
It should not be a problem and is not on Linux ... What appended when using the
(i.e. the one created by roottest's cmake)? |
Main problem was Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks Sergey! Let's see if Philippe agrees.
Try to avoid creation of many temporary files in source directory where macro is situated.
Most significant drawback has on Windows when several files has to be moved or deleted from source directory
Need to adjust several existing tests to correctly configure fixtures (dependencies) between tests.
Re-enable
cling/templateMembers/runtemplateMembers
test which was not included in cmake before, but exists in MakefileSeveral failures was due to fact that both compiled and interpreted version of macro need to be running.
To exclude interference - I add deletion of compiled code and configure strict dependency: