Skip to content

[roottest] move reflex test from io/evolution to subdir #19088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[roottest] move reflex test from io/evolution to subdir #19088

wants to merge 1 commit into from

Conversation

linev
Copy link
Member

@linev linev commented Jun 18, 2025 •
edited
Loading

Generated reflex library may be incomplete when other tests running,
causing failure messages. Instead creating dependency for each tests
just move reflex dictionary generation to separate dir

@linev linev self-assigned this Jun 18, 2025
@linev linev requested a review from bellenot as a code owner June 18, 2025 15:16
@linev
[roottest] move reflex test in io/evolution/foreign10 to separate dir
43626a6 
Generated reflex library may be incomplete when other tests running,
causing failure messages. Instead creating dependency for each tests
just move reflex dictionary generation to separate dir
@linev linev force-pushed the roottest_io_evolution_dependency branch from 215a198 to 43626a6 Compare June 18, 2025 15:28
@linev linev requested a review from dpiparo as a code owner June 18, 2025 15:28
@linev linev changed the title [roottest] add dependency for root-io-evolution-foreign10 test [roottest] move reflex test from io/evolution to subdir Jun 18, 2025
pcanal
pcanal approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcanal
Copy link
Member

pcanal commented Jun 18, 2025

Generated reflex library may be incomplete when other tests running,
causing failure messages.

For the record what was the error message?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2025 •
edited
Loading

Test Results

    19 files      19 suites   3d 9h 37m 46s ⏱️
 3 016 tests  3 009 ✅ 0 💤 7 ❌
55 783 runs  55 776 ✅ 0 💤 7 ❌

For more details on these failures, see this check.

Results for commit 43626a6.

♻️ This comment has been updated with latest results.

@pcanal
Copy link
Member

pcanal commented Jun 18, 2025 •
edited
Loading

The pyunittests-bindings-pyroot-cppyy-cppyy-test-datatypes error seem unrelated. It seems that the dictionary step is generating (unwanted) rootmap file but it is 'strange' it only fails on one platform

Nevermind the last observation. The Warning about the duplicate rootmap file are on other platforms but do not lead to a failure (I assume the output of the test is being ignored).

So those failures are likely to 'just' be not-yet-addressed new incompatibility between cppyy and MacOS 26/xcode

@pcanal
Copy link
Member

pcanal commented Jun 18, 2025

(and the test was disable in this PR: #19069 )

@pcanal pcanal closed this Jun 18, 2025
@pcanal pcanal reopened this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal approved these changes

@bellenot bellenot bellenot approved these changes

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

Assignees

@linev linev

Labels
affects:master in:Build System in:Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linev @pcanal @bellenot