Skip to content

Fix token counting bug #19126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AtefEl-Hennnawy
Copy link

@AtefEl-Hennnawy AtefEl-Hennnawy commented Jun 18, 2025

Description

Fixes a minor bug in embedding token-counting within TokenCountingHandler.
The current implementation replaces \n with spaces (" ") before sending the prompt to the model (e.g., OpenAI), but this replacement is not applied when counting tokens locally.
This causes a mismatch between actual usage reported by the provider and what LlamaIndex estimates.

Fix

Added .replace("\n", " ") before counting tokens to align local counting with what is actually sent.

Fixes: No associated issue number (happy to file one if needed).

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually compared OpenAI API usage reports with TokenCountingHandler output after the fix

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants