Skip to content

Fix dashscope qwen assistant api Error response problem, extract tool_calls info from ChatMessage kwargs to top level. #19224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025

Conversation

dalei-wang
Copy link
Contributor

The original chat_message_to_dashscope_messages method transform llama ChatMessage to DashScope Message Dict only contains role and content key, but qwen assistant api with function call need "tool_calls" before tool role message, otherwise it will return an error like this:
<400> InternalError.Algo.InvalidParameter: messages with role "tool" must be a response to a preceeding message with "tool_calls".

Description

Modify chat_message_to_dashscope_messages method. When the message is in assistant or tool role. Extracting information such as tool_calls/tools from the JSON structure in ChatMessage's kwargs to the top level

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 26, 2025
…l keys to dashscope message.

"chat_message_to_dashscope_messages" transform llama ChatMessage to DashScope Message Dict, only contains role and content key, but qwen assistant api with function call need tool_calls before tool role message, otherwise it will return error:

<400> InternalError.Algo.InvalidParameter: messages with role "tool" must be a response to a preceeding message with "tool_calls".
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. lgtm This PR has been approved by a maintainer and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 30, 2025
@logan-markewich logan-markewich merged commit b55a52d into run-llama:main Jun 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants