-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
support --no-enable-chunked-prefill for V1 #19975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @liuyumoye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the configurability of the vLLM service by providing a mechanism to disable the chunked_prefill
feature for V1 via a command-line flag. It modifies the argument parsing logic to respect user-specified preferences over the default settings.
Highlights
- Configuration Control: This pull request introduces the ability to explicitly disable the
chunked_prefill
feature in vLLM's V1 service by allowing the--no-enable-chunked-prefill
command-line argument to override the default behavior. - Argument Parsing Logic: The
_set_default_args_v1
method invllm/engine/arg_utils.py
was modified. Previously,self.enable_chunked_prefill
was unconditionally set toTrue
for non-pooling tasks. Now, it is only set toTrue
if its value isNone
, ensuring that a user-provided argument can prevent this default assignment.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds support for disabling chunked prefill via the --no-enable-chunked-prefill
parameter for V1 of the vllm service. The code change ensures that the enable_chunked_prefill
attribute is only set to True
if it hasn't been explicitly set to False
by the user. I've suggested adding a comment to clarify the purpose of the conditional check.
if self.enable_chunked_prefill is None: | ||
self.enable_chunked_prefill = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a check for self.enable_chunked_prefill
being None
before setting it to True
. This is good, but it would be clearer to have a comment explaining why this check is necessary, especially in the context of the --no-enable-chunked-prefill
parameter. Consider adding a comment to clarify the purpose of this conditional check.
if self.enable_chunked_prefill is None: | |
self.enable_chunked_prefill = True | |
# Only enable chunked prefill if it hasn't been explicitly disabled via --no-enable-chunked-prefill | |
if self.enable_chunked_prefill is None: | |
self.enable_chunked_prefill = True |
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: liuyumoye <adeline_ly2023@outlook.com>
v0.9.1 cannot turn off the feature correctly
|
You should apply this patch to v0.9.1, but this patch is based main branch |
To my understanding, v1 engine does not support disable chunk prefill. Will this PR actually turn off chunk prefill? |
In this pr(https://github.com/vllm-project/vllm/pull/16188), ![]() If disable chunk prefill and current request's num_new_tokens is larger than token_budget, this request will not be scheduled in this round, it will be put into the skipped_waiting_requests queue to be scheduled first in the next round. ![]() |
Sorry for missing that PR. Bring the discussion here as the current scheduler logic is different from that of v0. |
support --no-enable-chunked-prefill for V1
When executing the vllm service, the chunked prefill feature can be turned off by passing the --no-enable-chunked-prefill parameter