Skip to content

eslint-plugin-prettier is generally not recommended #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yoshi-pi opened this issue Oct 29, 2022 · 2 comments
Closed

eslint-plugin-prettier is generally not recommended #15

yoshi-pi opened this issue Oct 29, 2022 · 2 comments

Comments

@yoshi-pi
Copy link

According to the official prettier Notes, eslint-plugin-prettier used in this package is generally not recommended since we can just use the editor extension to format the code.
I think Vue.js needs to follow suit and update create-vue's default prettier behavior and add a setup guide for prettier extensions like ESLint in the documentation.
@MartinX3
Copy link

MartinX3 commented Jul 5, 2023

And finally with prettier 3.0.0 it is not compatible anymore.

TypeError: prettier.resolveConfig.sync is not a function

@CommanderStorm CommanderStorm mentioned this issue Jul 5, 2023
Merged
1 task
@yoshi-pi
Copy link
Author

yoshi-pi commented Jul 7, 2023

I think this issue has been resolved by feat: add a skip-formatting ruleset

@yoshi-pi yoshi-pi closed this as completed Jul 7, 2023
CommanderStorm added a commit to TUM-Dev/NavigaTUM that referenced this issue Jul 8, 2023
@CommanderStorm
used a different command for linting and formatting
ae5fd5d 
See https://github.com/vuejs/eslint-config-prettier#use-separate-commands-for-linting-and-formatting
Fixes vuejs/eslint-config-prettier#15 (comment)
CommanderStorm added a commit to TUM-Dev/NavigaTUM that referenced this issue Jul 9, 2023
@renovate @CommanderStorm
Update dependency prettier to v3 (#702)
0ece0fe 
* Update dependency prettier to v3

* used a different command for linting and formatting
See https://github.com/vuejs/eslint-config-prettier#use-separate-commands-for-linting-and-formatting
Fixes vuejs/eslint-config-prettier#15 (comment)

* applied fixes required by prettier

* fixed the locales using single/double quotes differently between the formatting script and check_locales.py

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinX3 @yoshi-pi