Skip to content

Define invalidResolutionOptions error #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wip-abramson opened this issue Apr 2, 2025 · 4 comments
Open

Define invalidResolutionOptions error #140

wip-abramson opened this issue Apr 2, 2025 · 4 comments
Labels
pr-exists There is an open PR to address this issue.

Comments

@wip-abramson
Copy link
Contributor

I believe we should add a invalidResolutionOptions error.

The specific case I am thinking of is when someone attempts to resolve a DID with both versionId and versionTime specified. These are intended to be mutually exclusive per the spec. Although that is currently only stated in section 12 - https://w3c.github.io/did-resolution/#versioning. Perhaps this should also be added to the definitions of these options.

As DID methods define and use other options this error could also apply.

@peacekeeper
Copy link
Collaborator

I agree, this seems useful.

@wip-abramson
Copy link
Contributor Author

Wondering if this should be generalized. to INVALID_OPTIONS or INVALID_RESOLVER_OPTIONS.

This would the cover the dereferencing options too. Or we could add two errors. One for INVALID_DEREFERENCING_OPTIONS?

@peacekeeper
Copy link
Collaborator

I don't have a strong opinion on this. I think a single error INVALID_OPTIONS would be fine.

@wip-abramson
Copy link
Contributor Author

Yep, I tend to agree. Updated PR #146 to include this option.

@wip-abramson wip-abramson added pr-exists There is an open PR to address this issue. and removed ready-for-pr Issue is ready for a PR labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-exists There is an open PR to address this issue.
Projects
None yet
Development

No branches or pull requests

2 participants