Update examples and diagrams in section 7. #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peacekeeper
requested review from
msporny,
dlongley,
jandrieu,
mccown and
wip-abramson
peacekeeper
requested review from
dmitrizagidulin,
ChristopherA and
danpape
as code owners
wip-abramson
reviewed
May 2, 2025
msporny
approved these changes
May 15, 2025
There was a problem hiding this comment.
LGTM at a high level, but agree with @wip-abramson -- can we remove the section headings?
|
This was discussed during the #did meeting on 15 May 2025. View the transcriptw3c/did-resolution#143wip: more diagrams.... I had commented on the heading titles... perhaps we can be more descriptive.... markus_sabadello: yes, I agree wondering if they should be headings or not.... wip: yes because the figure already describes the diagram.... <manu> +1 to not using headings and use figure anchors to link instead wip: ok... |
peacekeeper
force-pushed
the
peacekeeper-diagrams-section-7
branch
from
d849f9e to
bf8bb5e
Compare
|
@msporny @wip-abramson I added a commit which now combines the three "Example" subsections into one "Examples", which is consistent with other parts of the spec. |
|
Merging after approval and addressed feedback (about "Example" headings). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the examples and diagrams in section 7 in a few ways:
Partially addresses #28 and #128.
I'm working on several more updates for section 7 (DID Resolution Architectures), to address a few topics related to trust in DID Resolution. This PR here is a first step, cleaning up the diagrams.
Preview | Diff