Remove Sec- prefixes #160
Merged
Remove Sec- prefixes #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefrog-gh
approved these changes
May 5, 2025
| @@ -218,7 +218,7 @@ In order to use DBSC, site owners need to establish two new endpoints: | |||
| the registration endpoint and the refresh endpoint. | |||
There was a problem hiding this comment.
Do you want to update the public explainer as well? (though would that be confusing for folks wanting to participate in the OT?)
There was a problem hiding this comment.
Yeah I think this is one where we should not update the explainer. I think we can update the explainer after the OT, but I don't want to confuse people.
There was a problem hiding this comment.
Sounds good to me. Can we have a way to track this so we don't forget?
There was a problem hiding this comment.
added 2 commits
May 5, 2025 15:28
This is meaningless on the response headers, and on the Sec-Session-Response, the server needs to carefully validate that the expected key is being used anyway. It does seem kind of nice if the server can trust that the Sec-Session-Id is truly coming from the site instead of an XHR, so that it can look up the right expected public key for the Sec-Session-Response, so we leave the Sec- prefix on that one header. Following the discussion on #59, we make the shared prefix Secure-Session- instead.
github-actions bot
added a commit
that referenced
this pull request
May 5, 2025
SHA: 832fb1f Reason: push, by drubery Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meaningless on the response headers, and on the Sec-Session-Response, the server needs to carefully validate that the expected key is being used anyway. It does seem kind of nice if the server can trust that the Sec-Session-Id is truly coming from the site instead of an XHR, so that it can look up the right expected public key for the Sec-Session-Response, so we leave the Sec- prefix on that one header. Following the discussion on
#59, we make the shared prefix Secure-Session- instead.