Skip to content

Confusing error message when linting outside of the WPT directory #51534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domenic opened this issue Mar 23, 2025 · 0 comments
Open

Confusing error message when linting outside of the WPT directory #51534

domenic opened this issue Mar 23, 2025 · 0 comments

Comments

@domenic
Copy link
Member

domenic commented Mar 23, 2025

#9879 helped me run the WPT lint on jsdom tests, thanks!

However, I get error message, which does not have any impact on the exit code of lint.py (and so I can ignore it), but is confusing:

fatal: ..\to-upstream\lint.ignore: '..\to-upstream\lint.ignore' is outside repository at 'C:/Users/d/OneDrive - domenic.me/Code/GitHub/jsdom/jsdom/test/web-platform-tests/tests'

Setup:

outer/wpt             (<-- full WPT checkout)
outer/to-upstream

CD to outer/wpt

Run:

python ./wpt.py lint --repo-root ../to-upstream --all

This successfully lints the tests in outer/to-upstream, and even applies the ignore file at outer/to-upstream/lint.ignore.

But it gives the above confusing message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants