Extend geolocation tests #52243
Merged
Extend geolocation tests #52243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geolocation/enabled.https.html
Outdated
| }); | ||
|
|
||
| // Ensure any previously set geolocation emulations are cleared. | ||
| await test_driver.bidi.emulation.set_geolocation_override( |
There was a problem hiding this comment.
I don't think we have agreement on the shape of the BiDi API? @reillyeon?
There was a problem hiding this comment.
There was a problem hiding this comment.
w3c/geolocation#183 was merged based on consensus between Chromium and Firefox.
marcoscaceres
previously requested changes
Apr 30, 2025
sadym-chromium
force-pushed
the
sadym/geolocation-internal-wpt
branch
from
af97157 to
55fec53
Compare
OrKoN
approved these changes
Apr 30, 2025
reillyeon
requested changes
Apr 30, 2025
sadym-chromium
force-pushed
the
sadym/geolocation-internal-wpt
branch
from
55fec53 to
595d3c7
Compare
reillyeon
approved these changes
May 5, 2025
|
@marcoscaceres please take a look |
sadym-chromium
force-pushed
the
sadym/geolocation-internal-wpt
branch
from
595d3c7 to
800ff96
Compare
sadym-chromium
force-pushed
the
sadym/geolocation-internal-wpt
branch
from
800ff96 to
dbf6924
Compare
sadym-chromium
dismissed
marcoscaceres’s stale review
I assume the concerns raised by @marcoscaceres are addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy Chromium's wpt-internal test to public WPT using testdriver geolocation API.