add a job that check all other job status #3230
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3230 +/- ##
=========================================
Coverage 71.41% 71.41%
Complexity 2948 2948
=========================================
Files 118 118
Lines 11633 11633
=========================================
Hits 8308 8308
Misses 3325 3325
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
cbeauchesne
force-pushed
the
cbeauchesne/all-jobs-are-green
branch
from
28f9055 to
2f10573
Compare
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Run Ensure CI Success | ||
| uses: DataDog/ensure-ci-success@v1 |
There was a problem hiding this comment.
We've built something similar to replace https://github.com/upsidr/merge-gatekeeper in our CI - https://github.com/lendable/sloth - maybe you would be interested in joining the effort? 😊
There was a problem hiding this comment.
gosh, I crawl the web to find an action that fits my needs, and I missed yours 🤕 .
Unfortunately, I won't be able to join, as go is chineese to me.
Though, I'll put some suggestion easy to tackle that would have been a blocker for me. If at some point it's a good fit, I'll consider using yours!
Thank's a lot for the head's up!
There was a problem hiding this comment.
No worries, ours is the latter one though (sloth), which is in TypeScript :)
There was a problem hiding this comment.
I'm not going to merge this currently.
This request changes is not a request for changes today, but for changes in the future, around ignored-name-patterns.
The reason is that we're in the middle of migration to gitlab CI, which currently has more flaky and non-working tests, which we might have to merge within the next two weeks, even with not all issues resolved.
This requirement will then be ugly and with possibly many exceptions.
I'd like to revisit this PR again within a month though.
|
Hi @bwoebi ,
At least, other jobs will be in required list. My point is that if we wait to have enough healthy jobs to move forward, we'll probably never move forward, as some jobs may become unhealthy while we're fixing other. I totally understand the burden of maintaining a big list, that's why I used regexes for this parameters, please let me know if it can be a good fit. |
|
@cbeauchesne This is pointless though as within two weeks all ci/circleci will disappear, leaving this check effectively checking nothing then. It's not "wait for enough healthy jobs", but "let's merge gitlab and wait 1-2 weeks to see where it's actually unstable and then apply this". |
Description
Add a job in the CI that runs in PR. The job will be a success if all other jobs are skipped/success, and fails otherwise
Motivation
While it's possible to enforce a green CI policy using GitHub's native "required status checks" feature, doing so requires explicitly listing all job names under branch protection rules. This approach has two key drawbacks:
This jobs will check ALL other job, and we'll be able to set this as a requirement. The action used offers a
ignored-name-patternsparameters`, I added few job that failed on that PR, let me know if others should be added.the plan is to merge this PR, wait few days to be sure that everything is fine. Then add it as a requirement.
Reviewer checklist