Honor new application DSL from KMP 2.1.20 #1333
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Goooler
changed the title
Goooler
force-pushed
the
g/20250311/kotlin-new-app-block
branch
from
a717e7b to
1bcf07c
Compare
This was referenced Mar 11, 2025
…-app-block // Conflicts: // src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt
1 task
Goooler
changed the title
Goooler
force-pushed
the
g/20250311/kotlin-new-app-block
branch
from
7e18fc7 to
579f1d3
Compare
…-app-block // Conflicts: // src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/KmpPluginTest.kt
Goooler
force-pushed
the
g/20250311/kotlin-new-app-block
branch
from
579f1d3 to
1d6150a
Compare
…-app-block // Conflicts: // src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/BasePluginTest.kt
Goooler
force-pushed
the
g/20250311/kotlin-new-app-block
branch
from
200d077 to
c566f27
Compare
Goooler
commented
Mar 24, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowKmpAppPlugin.kt
Outdated
Show resolved
Hide resolved
1 task
…-app-block # Conflicts: # src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/KotlinPluginsTest.kt
…-app-block # Conflicts: # src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowKmpPlugin.kt
Goooler
commented
Apr 8, 2025
Comment on lines
+68
to
+69
| target.binaries { | ||
| executable { dsl -> |
There was a problem hiding this comment.
Any way to defer binaries and executable? I see binariesDsl is private, we can't use it...
CC @antohaby
There was a problem hiding this comment.
I've created an issue to address this:
KT-77499 Provide a way to access and configure JVM binaries defined by users
There was a problem hiding this comment.
Thanks for this feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kotlinlang.org/docs/whatsnew2120.html#kotlin-multiplatform-new-dsl-to-replace-gradle-s-application-plugin